Make kick messages default to the kicker name instead of the kicked #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slingamn
reviewed
Aug 13, 2021
irc/handlers.go
Outdated
| @@ -1373,6 +1373,9 @@ func kickHandler(server *Server, client *Client, msg ircmsg.Message, rb *Respons | |||
| if len(msg.Params) > 2 { | |||
| comment = msg.Params[2] | |||
| } | |||
| if comment == "" { | |||
| comment = client.nick | |||
There was a problem hiding this comment.
What's the difference?
There was a problem hiding this comment.
Synchronization:
Lines 148 to 152 in 4785a39
Technically, unsynchronized access to (*Client).nick is a data race, although in a context like this I think the only thing it could race against in practice is SANICK.
For consistency with RFC2812, Bahamut, Hybrid, Insp, Plexus4, Unreal. https://datatracker.ietf.org/doc/html/rfc2812#section-3.2.8 At the expense of consistency with chary/solanum, irc2, and ircu2.
progval
force-pushed
the
kick-default-comment
branch
from
1db8d03
to
f33f41b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with RFC2812, Bahamut, Hybrid, Insp, Plexus4, Unreal.
https://datatracker.ietf.org/doc/html/rfc2812#section-3.2.8
At the expense of consistency with chary/solanum, irc2, and ircu2.
Will be tested by irctest: progval/irctest#100