Provide a solution to create/update reference screenshots #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphiz
force-pushed
the
add-update-screenshots-functionallity
branch
from
d14a124
to
d285a73
Compare
mloydd
approved these changes
May 29, 2023
pixelpact/src/render.test.js
Outdated
| it("screenshot takes a screenshot of the given url", async () => { | ||
| await renderer.start(); | ||
|
|
||
| const screenshot = await renderer.screenshot("https://ergon.ch"); |
There was a problem hiding this comment.
This test will fail if ergon.ch website is down.
There was a problem hiding this comment.
Yes, I'm not 100% happy with this test case, but since the renderer accepts an URL, this was the easiest thing to get it to green. The safe way to do it would be to spin up a local server and use this url instead - however, this would make the test much more complex. I think for now, it's fine to ignore this, ok?
pixelpact/src/helpers.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| export function getLocalAddress(fastifyInstance) { | |||
| let address = fastifyInstance.addresses().find((e) => e.family === "IPv4"); | |||
There was a problem hiding this comment.
Suggested change
| let address = fastifyInstance.addresses().find((e) => e.family === "IPv4"); | |
| const address = fastifyInstance.addresses().find((e) => e.family === "IPv4"); |
There was a problem hiding this comment.
address can potentially be undefined. I think we need to check for the undefined case.
There was a problem hiding this comment.
Will throw here an explicit exception if address is undefined
raphiz
force-pushed
the
add-update-screenshots-functionallity
branch
from
332e2e7
to
b27896e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.