Upgrade to sigma v5.0.8 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrStahlfelge
reviewed
Jun 1, 2023
There was a problem hiding this comment.
This looks good overall, but the package change for ErgoToken and ErgoId will make changes needed in client code as these are widely used in public methods. Should be stated in the migration file or by adding deprecated empty subclasses (org.ergoplatform.appkit.ErgoToken extends org.ergoplatform.sdk.ErgoToken)
|
@MrStahlfelge, tried to add empty classes. This hasn't ended up well, because class duplication somehow confuses Scala 2.11, but not Scala 2.12, 2.13. Will also add migration note in release notes. |
MrStahlfelge
approved these changes
Jun 1, 2023
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
$.MODULE$removed where possibleNo tests changed, despite many changes the backward compatibility is preserved.