Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Message class #2105

Closed
ccellado opened this issue Jan 24, 2024 · 0 comments · Fixed by #2113
Closed

Refactor Message class #2105

ccellado opened this issue Jan 24, 2024 · 0 comments · Fixed by #2113
Assignees
@ccellado
Labels
B-200 SigUSD

Comments

@ccellado
Copy link
Collaborator

ccellado commented Jan 24, 2024 •
edited

Message class is mandatory in all p2p communication and required in ergo-core, but in current implementation tied heavily to ergo-node

  1. Decouple Message and its codecs from the ConnectedPeer part
  2. Remove the akka.util dependency in codec
  3. Update ergo-core readme with usage of the codecs
@ccellado ccellado self-assigned this Jan 25, 2024
@ccellado ccellado mentioned this issue Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccellado ccellado

Labels
B-200 SigUSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor message ccellado/ergo
2 participants
@kushti @ccellado