Refactor message #2113
Merged
Refactor message #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move appropriate specs to core
Move appropriate specs to core
# Conflicts: # ergo-core/README.md # ergo-core/src/main/scala/org/ergoplatform/network/message/InvSpec.scala # src/main/scala/org/ergoplatform/network/message/BasicMessagesRepo.scala
Fix tag filename
…otfix Hotfix binary release
More tests for ContextExtension semantics
ergo-core documentaton & refactorings
fix proofHash related sporadic concurrency bug
Fix for ergoplatform#2106 : MaxHeaders constant is used instead of epochLength related value in chainSlice limit
Add changes to ergo-core readme
Add changes to ergo-core readme
kushti
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2105
Removing
akka.util.ByteStringdependency is not possible, since all deserialization is consumed byakka.Tcp, which it's tied to.Extracted
MessageBasetrait fromMessage.Since other network solutions could require its own data classes and
scorex.util.Serializationnot available, due to tis specialty, it for now will be on theergo-corelibrary user's side to decide how to decode and encode those messages.Node's
Messageserializer now requiresMessageBase, so any inherited message type should work