Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BIP32 secret key derivation (child key < 32 bytes) in ergo-wallet #1636

Merged
merged 12 commits into from
Oct 5, 2022
Merged

Fix BIP32 secret key derivation (child key < 32 bytes) in ergo-wallet #1636

merged 12 commits into from
Oct 5, 2022

Commits on Sep 22, 2022

  1. add test case for incorrect BIP32 private child key derivation;

    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    7ee2521 View commit details
    Browse the repository at this point in the history

  2. add comment to ExtendedSecretKey derivation explaining 

    less-than-32-bytes child key bug;
    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    a5e6115 View commit details
    Browse the repository at this point in the history

  3. introduce ExtendedSecretKey.usePre1627KeyDerivation 

    and fix BIP32 secret key derivation;
    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    34b9817 View commit details
    Browse the repository at this point in the history

  4. update openapi.yaml with added usePre1627KeyDerivation option 

    for wallet restore endpoint;
    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    fc50861 View commit details
    Browse the repository at this point in the history

  5. fix comment;

    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f6a0f9f View commit details
    Browse the repository at this point in the history

  6. add WalletApiRoute test for missing key derivation option rejection;

    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    9e0c5ea View commit details
    Browse the repository at this point in the history

  7. add usePre1627KeyDerivation tests in JsonSecretStorage 

    for new, restored and pre-1627(migration) wallets;
    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    5a0756a View commit details
    Browse the repository at this point in the history

  8. fix doc comments;

    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4d48979 View commit details
    Browse the repository at this point in the history

  9. fix doc comments;

    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    380384c View commit details
    Browse the repository at this point in the history

  10. fix CreateTransactionDemo build;

    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    32ff3ef View commit details
    Browse the repository at this point in the history

  11. Use pre-1627 derivation in ergo node;

    @greenhat
    greenhat committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    71f62a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Merge branch 'v4.0.104' of github.com:ergoplatform/ergo into 1627-der… 

    …ive-both
    @kushti
    kushti committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e1a1f8b View commit details
    Browse the repository at this point in the history