Comparing pay-to-reemission trees by proposition #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
approved these changes
Jun 4, 2022
aslesarenko
reviewed
Jun 6, 2022
| out.ergoTree == payToReemissionContract | ||
| } else { | ||
| out.ergoTree.toProposition(true) == payToReemissionContract.toProposition(true) | ||
| } |
There was a problem hiding this comment.
could you please describe, why the original comparison out.ergoTree == payToReemissionContract won't affect mainnet?
Also, shoudn't testnet also have protocol upgrades to be on par with mainnet?
There was a problem hiding this comment.
The testnet was activated with old clients, issuing and accepting (the most important part) v0 transactions burning re-emission tokens while sending ERGs to pay-to-reemission outputs. Such transactions appeared in block #206,155. Mainnet has no such transactions in the mainnet (and they could be problematic after EIP-27 activation only).
To be on par, we need for testnet relaunch at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1726 :
There's a consensus-level disagreement affecting testnet (only). As pay-to-reemission tree is switched to v1 in 78a8bfc (merged into 4.0.29), and comparison is done over the trees during transaction validation, 4.0.29+ and prior versions currently disagree on transactions burning re-emission tokens (while paying to pay-to-reemission outputs).
As a solution, we now compare trees by propositions. Done for the testnet only, in the mainnet, to avoid disagreement with older versions, we compare trees as before.