Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErgoSyncTracker rework #1769

Merged
merged 12 commits into from Jul 24, 2022
Merged

ErgoSyncTracker rework #1769

merged 12 commits into from Jul 24, 2022

Conversation

kushti
Copy link
Member

@kushti kushti commented Jul 6, 2022 •
edited

In this PR:

  • close Clear status in ErgoSyncTracker after some time  #1774 : after enough time passed we clear status for potentially stalled peer. Helps when the peer is still recognized as connected (but in fact could be disconnected), but the node can query it still because peer status from the past looks good
  • update status functionality fully moved to StatusTracker

@kushti kushti changed the base branch from master to envs-refactoring July 6, 2022 23:10
Base automatically changed from envs-refactoring to v4.0.35 July 8, 2022 19:28
@kushti kushti changed the base branch from v4.0.35 to v4.0.36 July 21, 2022 22:24
@pragmaxim
Copy link
Collaborator

@kushti does this close #1774 ?

@kushti
Copy link
Member Author

kushti commented Jul 22, 2022

@pragmaxim now yes (wasnt so during your quection)

@pragmaxim pragmaxim self-requested a review July 22, 2022 15:33
pragmaxim
pragmaxim reviewed Jul 22, 2022
View reviewed changes
src/main/scala/org/ergoplatform/network/ErgoSyncTracker.scala
(if (elders.nonEmpty) elders(scala.util.Random.nextInt(elders.size)) +: unknowns else unknowns) ++ forks

val eldersAndUnknown = if (elders.nonEmpty) {
elders(scala.util.Random.nextInt(elders.size)) +: unknowns
Copy link
Collaborator

@pragmaxim pragmaxim Jul 22, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushti why do we pick only one older and all unkowns and forks 🤔 ? That might probably deserve a comment

@kushti kushti merged commit c2e70df into v4.0.36 Jul 24, 2022
@kushti kushti deleted the status-rework branch July 24, 2022 20:35
@kushti kushti mentioned this pull request Jul 24, 2022
Merged
@kushti kushti restored the status-rework branch July 24, 2022 20:40
@kushti kushti deleted the status-rework branch August 22, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslesarenko aslesarenko aslesarenko approved these changes

@pragmaxim pragmaxim pragmaxim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kushti @pragmaxim @aslesarenko