i1768 - transactions and wallet api to return Bad Request on invalid tx #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragmaxim
requested review from
kushti,
MrStahlfelge and
greenhat
and removed request for
MrStahlfelge
greenhat
approved these changes
Jul 23, 2022
kushti
approved these changes
Jul 28, 2022
| } | ||
| } | ||
|
|
||
| def checkTransactionR: Route = (path("check") & post & entity(as[ErgoTransaction])) { tx => | ||
| validateTransactionAndProcess(tx) { tx => tx } | ||
| validateTransactionAndProcess(tx) { tx => Future.successful(()) } |
| nodeViewActorRef ! LocallyGeneratedTransaction(tx) | ||
| (nodeViewActorRef ? LocallyGeneratedTransaction(tx)) | ||
| .mapTo[ProcessingOutcome] | ||
| .flatMap { |
There was a problem hiding this comment.
This code is also duplicated in WalletApiRoute, can be unified somehow?
| memoryPool().process(tx, minimalState()) match { | ||
| case (newPool, ProcessingOutcome.Accepted) => | ||
| log.debug(s"Unconfirmed transaction $tx added to the memory pool") | ||
| val newVault = vault().scanOffchain(tx) | ||
| updateNodeView(updatedVault = Some(newVault), updatedMempool = Some(newPool)) | ||
| context.system.eventStream.publish(SuccessfulTransaction(tx)) | ||
| ProcessingOutcome.Accepted |
There was a problem hiding this comment.
You can memoize processing result and thus eliminate 2 LoC
|
Nice comments, shared logic extracted to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1768
P.S. I did the same for wallet API as there was a similar case