EIP-39: monotonic creation height rule #1865
Conversation
kushti
requested review from
pragmaxim,
aslesarenko,
greenhat and
MrStahlfelge
src/main/scala/org/ergoplatform/modifiers/mempool/ErgoTransaction.scala
Outdated
Show resolved
Hide resolved
|
|
||
| val tokens = boxCandidate.additionalTokens.map { case (id, amount) => | ||
| if (java.util.Arrays.equals(id, assetId)) assetId -> deltaFn(amount) else assetId -> amount | ||
| } |
There was a problem hiding this comment.
The search over boxCandidate.additionalTokens happens 3 times. Passing an index in additionalTokens will be both faster and cleaner.
| } | ||
|
|
||
| private def checkTx(from: IndexedSeq[ErgoBox], wrongTx: ErgoTransaction): Try[Int] = { | ||
| wrongTx.statelessValidity().flatMap(_ => wrongTx.statefulValidity(from, emptyDataBoxes, emptyStateContext)) |
There was a problem hiding this comment.
please add comment on why it is called wrongTx?
There was a problem hiding this comment.
Out of scope of this PR, renamed to tx anyway
…ion.scala Co-authored-by: Alexander Slesarenko <aslesarenko@users.noreply.github.com>
…onic-creationheight
…go into monotonic-creationheight
Do you mean "its creation height is not less or equal to than max creation height in inputs" ? |
There are other inputs (with much higher heights) besides the pool box in the update tx. |
not less means equal or greater |
In this PR, EIP-39 (ergoplatform/eips#80) is implemented as follows: