New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for soft-forked acceptance of Ergoscript containing unknown methods (after 6.0 activation) #2146
Merged
+53
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccellado
approved these changes
Apr 24, 2024
jellymlg
approved these changes
Apr 25, 2024
aslesarenko
reviewed
Apr 26, 2024
src/test/scala/org/ergoplatform/modifiers/mempool/ErgoNodeTransactionSpec.scala
Outdated
Show resolved
Hide resolved
aslesarenko
reviewed
Apr 26, 2024
// the following ergo tree contains SBigInt.nbits method which is not supported by this client (as of 5.x version) | ||
// ergo tree version is 3, less value (e.g. version = 2 which gives 1a130206022edf0580fcf622d193db060873007301) | ||
// also works | ||
val ergoTree = DefaultSerializer.deserializeErgoTree(Base16.decode("1b130206022edf0580fcf622d193db060873007301").get) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ergoTree is UnparsedErgoTree? Maybe add the assertion.
…sactionSpec.scala Co-authored-by: Alexander Slesarenko <aslesarenko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR , a new test is added.
In this test we check how current version of the node (block protocol v3, at the moment of writing this test) will
execute a script which contains a method added in next version of the protocol (namely, BIgInt.nbits), which
is unknown to the node.
As shown in the test, rule #1110 (CheckAndGetMethod) should be replaced for new methods to be passed by the node not recognizing it.