BASE_FEE from config file with default ergo_lib::wallet::tx_builder::SUGGESTED_TX_FEE() #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2956049993
💛 - Coveralls |
greenhat
requested changes
Aug 29, 2022
core/src/oracle_config.rs
Outdated
| @@ -125,6 +127,10 @@ lazy_static! { | |||
| pub static ref ORACLE_CONFIG: OracleConfig = OracleConfig::load().unwrap(); | |||
| pub static ref MAYBE_ORACLE_CONFIG: Result<OracleConfig, String> = | |||
| OracleConfig::load().map_err(|e| e.to_string()); | |||
| pub static ref SAFE_USER_MIN: BoxValue = MAYBE_ORACLE_CONFIG | |||
There was a problem hiding this comment.
I suggest to name it BASE_FEE (close to OracleConfig::base_fee). SAFE_USER_MIN name comes from a box value minimal value limit (to prevent dust) and has nothing to do with tx fee.
The use of BoxValue::SAFE_USER_MIN for tx fee throughout the code was incorrect in the first place and should be avoided. There is ergo_lib::wallet::tx_builder::SUGGESTED_TX_FEE() intended for this case. Please, use it if config is unavailable.
There was a problem hiding this comment.
You are right. Changes have been made.
hanbu97
changed the title
|
Please, make Clippy happy. :) |
|
Clippy is happy now. 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.