New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newtypes for BlockHeight/EpochLength/etc #215
Conversation
238f5a6
to
1177949
Compare
Pull Request Test Coverage Report for Build 4134624236
💛 - Coveralls |
Hmm, other than the coveralls pipeline failing (#225), this should be ready to review |
da5b837
to
81915fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thank you!
I think generic ergo types like BlockHeight
will eventually make their way into the ergo-lib.
#[serde(transparent)] | ||
pub struct BlockHeight(pub u32); | ||
|
||
impl std::ops::Sub<EpochLength> for BlockHeight { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Closes #152