Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vote-update reward token parameter optional #228

Merged
merged 15 commits into from Mar 2, 2023

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Feb 14, 2023

Close #173
Close #219
Close #226
Close #159

Todo:

use SpecToken for reward tokens in vote-update and update-pool commands;
@coveralls
Copy link

coveralls commented Feb 15, 2023

Pull Request Test Coverage Report for Build 4312462594

  • 52 of 122 (42.62%) changed or added relevant lines in 17 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.4%) to 61.001%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/oracle_config.rs 0 2 0.0%
core/src/box_kind/ballot_box.rs 15 18 83.33%
core/src/cli_commands/prepare_update.rs 0 5 0.0%
core/src/cli_commands/vote_update_pool.rs 2 9 22.22%
core/src/explorer_api/explorer_url.rs 0 10 0.0%
core/src/explorer_api.rs 0 11 0.0%
core/src/main.rs 0 14 0.0%
core/src/cli_commands/update_pool.rs 5 23 21.74%
Files with Coverage Reduction New Missed Lines %
core/src/cli_commands/update_pool.rs 1 53.96%
core/src/cli_commands/vote_update_pool.rs 1 60.71%
core/src/main.rs 1 0%
core/src/cli_commands/prepare_update.rs 3 67.05%
Totals Coverage Status
Change from base Build 4144149595: -0.4%
Covered Lines: 2035
Relevant Lines: 3336

💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review March 2, 2023 09:12
add `import-pool-update` command description in the readme;
@greenhat greenhat merged commit 32a41ed into develop Mar 2, 2023
@greenhat greenhat deleted the i173-reward-tokens-update branch March 2, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants