Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intstructions in the IncorrectNumberOfRewardTokensInOracleBox error. Add details to error messages. #263

Merged
merged 2 commits into from Apr 13, 2023
Merged

Add intstructions in the IncorrectNumberOfRewardTokensInOracleBox error. Add details to error messages. #263

merged 2 commits into from Apr 13, 2023

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Apr 12, 2023 •
edited

Close #260

Done:

  • switch to anyhow::Error in other commands;
  • switch to thiserror #[from] in error types(enums);
  • ensure {:?} formatting for anyhow errors in logs;

@greenhat
Add intstructions in the IncorrectNumberOfRewardTokensInOracleBox error;
47651fd 
switch to anyhow::Error for transfer_oracle_token;
@github-actions
Copy link

Pull Request Test Coverage Report for Build 4676094461

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.389%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/main.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 4665794712: 0.0%
Covered Lines: 2049
Relevant Lines: 3393
💛 - Coveralls

@greenhat
switch to anyhow::Error in the rest of the commands and main loop;
d612248 
switch from `derive_more::From` to `anyhow` `#[from]` in error type
  variants;
@greenhat greenhat marked this pull request as ready for review April 13, 2023 07:25
@greenhat greenhat merged commit 1ef41d8 into develop Apr 13, 2023
7 checks passed
@greenhat greenhat deleted the i260-transfer-token-explain-error branch April 13, 2023 14:34
@greenhat greenhat changed the title Add intstructions in the IncorrectNumberOfRewardTokensInOracleBox error; Add intstructions in the IncorrectNumberOfRewardTokensInOracleBox error. Add details to error messages. Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make IncorrectNumberOfRewardTokensInOracleBox error to explain the action needed to resolve it
1 participant
@greenhat