Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERG/BTC Datapoint Sources #304

Merged
merged 3 commits into from Jul 24, 2023

Conversation

SethDusek
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jul 19, 2023

Pull Request Test Coverage Report for Build 5622633856

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.1%) to 54.633%

Files with Coverage Reduction New Missed Lines %
core/src/datapoint_source/erg_xau.rs 2 66.67%
core/src/datapoint_source/assets_exchange_rate.rs 4 50.0%
core/src/datapoint_source.rs 5 0%
core/src/datapoint_source/coingecko.rs 6 70.73%
core/src/pool_config.rs 6 66.67%
core/src/datapoint_source/bitpanda.rs 7 62.96%
core/src/datapoint_source/coincap.rs 7 62.96%
core/src/datapoint_source/predef.rs 9 0%
Totals Coverage Status
Change from base Build 5596499533: 0.1%
Covered Lines: 2093
Relevant Lines: 3831

💛 - Coveralls

@SethDusek SethDusek force-pushed the ergbtcdatapointsource branch 3 times, most recently from 9fd0bbd to 597087f Compare July 19, 2023 18:04
@SethDusek SethDusek marked this pull request as ready for review July 20, 2023 00:40
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you! Please take a look at my comments.

core/src/datapoint_source/assets_exchange_rate.rs Outdated Show resolved Hide resolved
core/src/datapoint_source/bitpanda.rs Outdated Show resolved Hide resolved
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@greenhat greenhat merged commit fa33c22 into ergoplatform:develop Jul 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants