Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scans being registered twice in Command::Run #96

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

SethDusek
Copy link
Collaborator

@SethDusek SethDusek commented Aug 12, 2022

Hi, relatively minor issue I ran into while testing, but I noticed that scans for each type (pool/ballot/refresh/etc) were being registered twice when I ran oracle-core run for the first time (with scanIds.json removed). After testing it with other commands that also create a new OraclePool that were not having this issue, it seems the cause was that the HTTP Get API thread and the main thread in Command::Run were both running in parallel and registering scans twice.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2846619236

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 65.163%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/main.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/main.rs 1 0%
Totals Coverage Status
Change from base Build 2838643233: 0.0%
Covered Lines: 1964
Relevant Lines: 3014

💛 - Coveralls

Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you!
I think we should have only one instance. I made #97

@greenhat greenhat merged commit 18b1c7c into ergoplatform:develop Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants