Fix scans being registered twice in Command::Run #96
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, relatively minor issue I ran into while testing, but I noticed that scans for each type (pool/ballot/refresh/etc) were being registered twice when I ran oracle-core run for the first time (with scanIds.json removed). After testing it with other commands that also create a new OraclePool that were not having this issue, it seems the cause was that the HTTP Get API thread and the main thread in Command::Run were both running in parallel and registering scans twice.