make box builder set* methods return self;

ergoplatform · Oct 9, 2020 · db24653 · db24653
1 parent 7442c29
commit db24653
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/bindings/ergo-lib-wasm/src/ergo_box/box_builder.rs b/bindings/ergo-lib-wasm/src/ergo_box/box_builder.rs
@@ -29,8 +29,8 @@ impl ErgoBoxCandidateBuilder {
     }
 
     /// Set minimal value (per byte of the serialized box size)
-    pub fn set_min_box_value_per_byte(&mut self, new_min_value_per_byte: u32) {
-        self.0.set_min_box_value_per_byte(new_min_value_per_byte);
+    pub fn set_min_box_value_per_byte(self, new_min_value_per_byte: u32) -> Self {
+        ErgoBoxCandidateBuilder(self.0.set_min_box_value_per_byte(new_min_value_per_byte))
     }
 
     /// Get minimal value (per byte of the serialized box size)
@@ -39,8 +39,8 @@ impl ErgoBoxCandidateBuilder {
     }
 
     /// Set new box value
-    pub fn set_value(&mut self, new_value: BoxValue) {
-        self.0.set_value(new_value.into());
+    pub fn set_value(self, new_value: BoxValue) -> Self {
+        ErgoBoxCandidateBuilder(self.0.set_value(new_value.into()))
     }
 
     /// Get box value

diff --git a/ergo-lib/src/chain/ergo_box/box_builder.rs b/ergo-lib/src/chain/ergo_box/box_builder.rs
@@ -52,9 +52,9 @@ impl ErgoBoxCandidateBuilder {
     }
 
     /// Set minimal value (per byte of the serialized box size)
-    pub fn set_min_box_value_per_byte(&mut self, new_min_value_per_byte: u32) {
-        // TODO: return self
+    pub fn set_min_box_value_per_byte(mut self, new_min_value_per_byte: u32) -> Self {
         self.min_value_per_byte = new_min_value_per_byte;
+        self
     }
 
     /// Get minimal value (per byte of the serialized box size)
@@ -63,9 +63,9 @@ impl ErgoBoxCandidateBuilder {
     }
 
     /// Set new box value
-    pub fn set_value(&mut self, new_value: BoxValue) {
-        // TODO: return self
+    pub fn set_value(mut self, new_value: BoxValue) -> Self {
         self.value = new_value;
+        self
     }
 
     /// Get box value
@@ -136,10 +136,10 @@ mod tests {
 
     #[test]
     fn test_set_value() {
-        let mut builder =
-            ErgoBoxCandidateBuilder::new(BoxValue::SAFE_USER_MIN, force_any_val::<ErgoTree>(), 1);
         let new_value = BoxValue::SAFE_USER_MIN.checked_mul_u32(10).unwrap();
-        builder.set_value(new_value);
+        let builder =
+            ErgoBoxCandidateBuilder::new(BoxValue::SAFE_USER_MIN, force_any_val::<ErgoTree>(), 1)
+                .set_value(new_value);
         assert_eq!(builder.value(), &new_value);
         let b = builder.build().unwrap();
         assert_eq!(b.value, new_value);