Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read/Write register values in ErgoBox/ErgoBoxCandidate #116

Merged
merged 7 commits into from Oct 13, 2020
Merged

Read/Write register values in ErgoBox/ErgoBoxCandidate #116

merged 7 commits into from Oct 13, 2020

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Oct 12, 2020 •
edited

Close #89

  • cover with tests in ergo-lib;
  • tests in wasm;
  • rewrite builders to be &mut self and return nothing;

@coveralls
Copy link

coveralls commented Oct 12, 2020 •
edited

Pull Request Test Coverage Report for Build 755

  • 54 of 55 (98.18%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.562%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ergo-lib/src/chain/ergo_box/box_builder.rs 37 38 97.37%
Totals Coverage Status
Change from base Build 745: 0.4%
Covered Lines: 1961
Relevant Lines: 2319
💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review October 13, 2020 12:59
@greenhat greenhat merged commit 76f629a into develop Oct 13, 2020
@greenhat greenhat deleted the i89-box-regs-access-wasm branch October 13, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add register data serialization/deserialization in WASM API
2 participants
@greenhat @coveralls