Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokens support in TxBuilder and ErgoBoxCandidateBuilder #118

Merged
merged 29 commits into from Oct 28, 2020

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Oct 15, 2020

Close #88

Todo:

  • tx builder tests for minting and burning a token;
  • implement token selection in SimpleBoxSelector;
  • box builder tests for adding, minting token;
  • newtype for token amount;
  • token tests (including minting and burning) in JS;

@greenhat greenhat marked this pull request as ready for review October 19, 2020 12:09
convert Into to From for Constant construction from values;
@greenhat greenhat marked this pull request as draft October 20, 2020 09:27
@coveralls
Copy link

coveralls commented Oct 20, 2020

Pull Request Test Coverage Report for Build 822

  • 432 of 466 (92.7%) changed or added relevant lines in 18 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+2.2%) to 86.816%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergo-lib/src/wallet/tx_builder.rs 39 40 97.5%
ergo-lib/src/wallet/box_selector/simple.rs 215 220 97.73%
ergo-lib/src/chain/ergo_box/box_value.rs 37 49 75.51%
ergo-lib/src/chain/token.rs 22 38 57.89%
Files with Coverage Reduction New Missed Lines %
ergo-lib/src/wallet/tx_builder.rs 1 92.92%
Totals Coverage Status
Change from base Build 802: 2.2%
Covered Lines: 2318
Relevant Lines: 2670

💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review October 28, 2020 07:19
@greenhat greenhat merged commit 231e1d6 into develop Oct 28, 2020
@greenhat greenhat deleted the i88-builder-tokens branch October 28, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tokens support in TxBuilder and ErgoBoxCandidateBuilder
2 participants