Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ErgoBox.id on JSON deserialization and build it from scratch #55

Merged
merged 5 commits into from Jul 1, 2020

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Jun 29, 2020

Close #53

Todo:

  • ErgoBox serialization;
  • ErgoBox.id hash calculation (import blake2b256 impl);
  • skip id on JSON deserialization and build it from scratch after all fields are deserialized;

@coveralls
Copy link

coveralls commented Jun 29, 2020

Pull Request Test Coverage Report for Build 343

  • 92 of 100 (92.0%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.4%) to 73.97%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sigma-tree/src/chain/address.rs 0 1 0.0%
sigma-tree/src/serialization/ergo_box.rs 43 45 95.56%
sigma-tree/src/chain/ergo_box.rs 40 45 88.89%
Files with Coverage Reduction New Missed Lines %
sigma-tree/src/ergo_tree.rs 2 88.37%
Totals Coverage Status
Change from base Build 333: 1.4%
Covered Lines: 790
Relevant Lines: 1068

💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review June 30, 2020 15:11
@greenhat greenhat merged commit 9ec2047 into develop Jul 1, 2020
@greenhat greenhat deleted the i53-skip-boxid-json-deser branch July 1, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip box id on JSON deserialization (generate from scratch)
2 participants