Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErgoTree constant segregation support #79

Merged
merged 9 commits into from Aug 11, 2020

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Aug 4, 2020

Close #78

Todo:

  • substitute ConstantPlaceholder with Constant;
  • gracefully handle constant deserialization errors (produce ErgoTree);
  • implement ConstantStore;
  • test ConstantStore;
  • add SigmaByteWrite trait;
  • segregate constant on serialization;

@coveralls
Copy link

coveralls commented Aug 4, 2020

Pull Request Test Coverage Report for Build 503

  • 190 of 203 (93.6%) changed or added relevant lines in 28 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+2.9%) to 70.512%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sigma-tree/src/ast/constant.rs 1 2 50.0%
sigma-tree/src/eval/costs.rs 0 1 0.0%
sigma-tree/src/serialization/constant_placeholder.rs 19 21 90.48%
sigma-tree/src/serialization/expr.rs 14 16 87.5%
sigma-tree/src/serialization/fold.rs 0 2 0.0%
sigma-tree/src/serialization/sigma_byte_writer.rs 7 9 77.78%
sigma-tree/src/ergo_tree.rs 56 59 94.92%
Files with Coverage Reduction New Missed Lines %
sigma-tree/src/ergo_tree.rs 1 91.85%
Totals Coverage Status
Change from base Build 485: 2.9%
Covered Lines: 1198
Relevant Lines: 1699

💛 - Coveralls

@greenhat greenhat marked this pull request as ready for review August 11, 2020 10:22
@greenhat greenhat merged commit 51adbd5 into develop Aug 11, 2020
@greenhat greenhat deleted the ergotree-ser-const-segregation branch August 11, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add constant segregation support for ErgoTree
2 participants