Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core to latest "emojiart" #5

Closed
eric-lobdell opened this issue Jun 21, 2016 · 4 comments
Closed

Update Core to latest "emojiart" #5

eric-lobdell opened this issue Jun 21, 2016 · 4 comments

Comments

@eric-lobdell
Copy link
Owner

We used an old repo of EmojiArt. Need to update / merge with current master, here:
https://github.com/michaeldick/emojiart

@amitava82
Copy link
Collaborator

Which change do you want to merge from that repo? There are lot of changes in our current design. It'd be pain to merge.

@eric-lobdell
Copy link
Owner Author

eric-lobdell commented Jun 22, 2016

Oh, I wasn't entirely sure what would be good to update from his bundle. You're the React master, so if you don't see anything vital, we're good.

Just browsing his commits the only one I saw that would be nice to have is: miked1ck@aacfada --it auto scrolls the output as you type more so that you're always able to see the last input character.

@amitava82
Copy link
Collaborator

I'll bring that in.

amitava82 added a commit that referenced this issue Jun 23, 2016
eric-lobdell pushed a commit that referenced this issue Jun 23, 2016
scroll to current character #5
@eric-lobdell
Copy link
Owner Author

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants