Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Copy Paste Issue #9

Closed
eric-lobdell opened this issue Jun 22, 2016 · 18 comments
Closed

Resolve Copy Paste Issue #9

eric-lobdell opened this issue Jun 22, 2016 · 18 comments

Comments

@eric-lobdell
Copy link
Owner

When you copy the emoji art and then paste it into messenger, you get a result like this:

❄️❄️❄️❄️❄️❄️❄️❄️
/react-text react-text: 190 ❤️❤️❤️❤️❤️❤️❤️❤️
❤️❤️❄️❤️❤️❄️❤️❤️
❤️❄️❄️❤️❤️❄️❄️❤️
❄️❄️❄️❤️❤️❄️❄️❄️
❄️❄️❄️❤️❤️❄️❄️❄️
❄️❄️❄️❤️❤️❄️❄️❄️
❄️❄️❤️❤️❤️❤️❄️❄️
❄️❄️❄️❄️❄️❄️❄️❄️
/react-text react-text: 191 ❤️❤️❤️❤️❤️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❄️❄️❄️❄️❄️
❄️❤️❤️❤️❤️❤️❄️❄️
❄️❤️❤️❄️❄️❄️❄️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❤️❤️❤️❤️❤️❤️❤️❄️
❄️❄️❄️❄️❄️❄️❄️❄️
/react-text react-text: 192 ❄️❄️❤️❤️❤️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❤️❄️❄️❄️❄️
❄️❄️❤️❤️❤️❤️❄️❄️
❄️❄️❄️❄️❤️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❤️❤️❤️❄️❄️
❄️❄️❄️❄️❄️❄️❄️❄️
/react-text react-text: 193 ❤️❤️❤️❤️❤️❤️❤️❤️
❤️❤️❄️❤️❤️❄️❤️❤️
❤️❄️❄️❤️❤️❄️❄️❤️
❄️❄️❄️❤️❤️❄️❄️❄️
❄️❄️❄️❤️❤️❄️❄️❄️
❄️❄️❄️❤️❤️❄️❄️❄️
❄️❄️❤️❤️❤️❤️❄️❄️
❄️❄️❄️❄️❄️❄️❄️❄️

@amitava82
Copy link
Collaborator

Are you seeing these text /react-text react-text: 193?
I'm testing on Android, looks alright

@eric-lobdell
Copy link
Owner Author

Yeah on iOS and desktop when I paste that string appears.

@amitava82
Copy link
Collaborator

which desktop and browser?

@eric-lobdell
Copy link
Owner Author

Ah, you're right! it's only happening in Safari desktop / Safari mobile

@amitava82
Copy link
Collaborator

Clipboard is not supported in Safari https://clipboardjs.com/

@eric-lobdell
Copy link
Owner Author

eric-lobdell commented Jun 22, 2016

Well we don't need the button to actually copy the text. Are we using clipboard for the sole purpose of selecting all text? I figured on mobile:

  1. tap the button
  2. manually tap to copy text to native clipboard from web.
  3. paste anywhere

Then it would just behave as if you had copied a large string of text. On desktop, I thought we could copy text to the clipboard in one click, but if that's not the case, we can just do the same as mobile.

@amitava82
Copy link
Collaborator

No clipboard will automatically copy the code in clipboard. Selection is separate. I tried on Mac and Safari and it seems to copy correct code

❄️❄️❄️❄️❄️❄️❄️❄️
❄️❄️❤️❤️❤️❄️❄️❄️
❄️❄️❄️❤️❤️❤️❄️❄️
❄️❄️❤️❄️❤️❤️❄️❄️
❄️❄️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❤️❤️❤️❤️❄️
❄️❤️❄️❄️❄️❤️❤️❤️
❤️❤️❤️❄️❤️❤️❤️❤️
❄️❄️❄️❄️❄️❄️❄️❄️
❤️❤️❤️❤️❤️❤️❄️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❤️❤️❤️❤️❤️❤️❄️❄️
❄️❄️❄️❄️❄️❄️❄️❄️
❄️❄️❤️❤️❤️❄️❄️❄️
❄️❄️❄️❤️❤️❤️❄️❄️
❄️❄️❤️❄️❤️❤️❄️❄️
❄️❄️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❤️❤️❤️❤️❄️
❄️❤️❄️❄️❄️❤️❤️❤️
❤️❤️❤️❄️❤️❤️❤️❤️
❄️❄️❄️❄️❄️❄️❄️❄️
❤️❤️❤️❤️❤️❤️❄️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❄️❄️❤️❤️❄️
❤️❤️❤️❤️❤️❤️❄️❄️
❄️❄️❄️❄️❄️❄️❄️❄️
❄️❄️❤️❤️❤️❄️❄️❄️
❄️❄️❄️❤️❤️❤️❄️❄️
❄️❄️❤️❄️❤️❤️❄️❄️
❄️❄️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❤️❤️❤️❤️❄️
❄️❤️❄️❄️❄️❤️❤️❤️
❤️❤️❤️❄️❤️❤️❤️❤️
❄️❄️❄️❄️❄️❄️❄️❄️
❄️❄️❤️❤️❤️❄️❄️❄️
❄️❄️❄️❤️❤️❤️❄️❄️
❄️❄️❤️❄️❤️❤️❄️❄️
❄️❄️❤️❄️❄️❤️❤️❄️
❄️❤️❤️❤️❤️❤️❤️❄️
❄️❤️❄️❄️❄️❤️❤️❤️
❤️❤️❤️❄️❤️❤️❤️❤️
❄️❄️❄️❄️❄️❄️❄️❄️

@eric-lobdell
Copy link
Owner Author

Interesting. Let's consider this resolved until I can find steps to reproduce. There might be an issue with the way I'm packaging it, perhaps?

@amitava82
Copy link
Collaborator

Try with new packed script and let me know.

@eric-lobdell
Copy link
Owner Author

eric-lobdell commented Jun 23, 2016

Somehow it happens only when you paste into Messages app on a mac, from Safari browser:

  1. using Safari on OS X, type a word
  2. press "select emoji" button
  3. press CMD + C (copy output)
  4. paste into email = works fine
  5. paste into Apple Messages app = returns weird parse lines.

screen shot 2016-06-23 at 12 58 23 am

@eric-lobdell eric-lobdell reopened this Jun 23, 2016
@amitava82
Copy link
Collaborator

Are you copying with keyboard shortcut?
Which mac app is this?

@eric-lobdell
Copy link
Owner Author

Sorry, I updated my reproduction steps.

yes, I use keyboard shortcut CMD + C to copy and I'm pasting directly into the Mac (OS X) Messages app

@eric-lobdell
Copy link
Owner Author

Another update! This only occurs when you use Safari web browser and paste into Apple Messages app...

If you use chrome and paste into messages, it works fine.

@amitava82
Copy link
Collaborator

Well, I'm not sure how to track it down 😵

@eric-lobdell
Copy link
Owner Author

If this helps, I recorded side by side to document:

https://www.dropbox.com/s/8dx721ln2168h31/issue.mov?dl=0

@amitava82
Copy link
Collaborator

I'll create a repo case outside this app. If I can reproduce same issue then it either goes to React or Apple!

@amitava82
Copy link
Collaborator

Alright, It's a Bug either in React or Safari or Messenger or all of them :D
Bug reported in React: facebook/react#7106

@eric-lobdell
Copy link
Owner Author

Alright, it sounds like it's out of our hands. Thanks for digging into it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants