forked from microsoft/vscode-pull-request-github
-
Notifications
You must be signed in to change notification settings - Fork 0
/
.eslintrc.base.json
260 lines (260 loc) · 9.63 KB
/
.eslintrc.base.json
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
{
"env": {
"es6": true
},
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:import/errors",
"plugin:import/warnings",
"plugin:import/typescript",
"prettier"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2019,
"sourceType": "module",
"ecmaFeatures": {
"impliedStrict": true
}
},
"plugins": ["import", "@typescript-eslint"],
"reportUnusedDisableDirectives": true,
"root": true,
"rules": {
"new-parens": "error",
"no-async-promise-executor": "off",
"no-console": "off",
"no-constant-condition": ["warn", { "checkLoops": false }],
"no-caller": "error",
"no-case-declarations": "off", // TODO@eamodio revisit
"no-debugger": "warn",
"no-dupe-class-members": "off",
"no-duplicate-imports": "error",
"no-else-return": "off", // TODO@eamodio revisit
"no-empty": "off", // TODO@eamodio revisit
//"no-empty": ["warn", { "allowEmptyCatch": true }],
"no-eval": "error",
"no-ex-assign": "warn",
"no-extend-native": "error",
"no-extra-bind": "error",
"no-extra-boolean-cast": "off", // TODO@eamodio revisit
"no-floating-decimal": "error",
"no-implicit-coercion": "off",
"no-implied-eval": "error",
// Turn off until fix for: https://github.com/typescript-eslint/typescript-eslint/issues/239
"no-inner-declarations": "off",
"no-lone-blocks": "error",
"no-lonely-if": "off",
"no-loop-func": "error",
"no-multi-spaces": "off",
"no-prototype-builtins": "off",
"no-return-assign": "error",
"no-return-await": "off", // TODO@eamodio revisit
"no-self-compare": "error",
"no-sequences": "error",
"no-template-curly-in-string": "warn",
"no-throw-literal": "error",
"no-unmodified-loop-condition": "warn",
"no-unneeded-ternary": "error",
"no-use-before-define": "off",
"no-useless-call": "error",
"no-useless-catch": "error",
"no-useless-computed-key": "error",
"no-useless-concat": "error",
"no-useless-escape": "off",
"no-useless-rename": "error",
"no-useless-return": "off",
"no-var": "error",
"no-with": "error",
"object-shorthand": "off",
"one-var": "off", // TODO@eamodio revisit
// "one-var": ["error", "never"],
"prefer-arrow-callback": "off", // TODO@eamodio revisit
"prefer-const": "off",
"prefer-numeric-literals": "error",
"prefer-object-spread": "error",
"prefer-rest-params": "error",
"prefer-spread": "error",
"prefer-template": "off", // TODO@eamodio revisit
"quotes": ["error", "single", { "avoidEscape": true, "allowTemplateLiterals": true }],
// Turn off until fix for: https://github.com/eslint/eslint/issues/11899
"require-atomic-updates": "off",
"semi": ["error", "always"],
"semi-style": ["error", "last"],
"sort-imports": [
"error",
{
"ignoreCase": true,
"ignoreDeclarationSort": true,
"ignoreMemberSort": false,
"memberSyntaxSortOrder": ["none", "all", "multiple", "single"]
}
],
"yoda": "error",
"import/export": "off",
"import/extensions": ["error", "never"],
"import/named": "off",
"import/namespace": "off",
"import/newline-after-import": "warn",
"import/no-cycle": "off",
"import/no-dynamic-require": "error",
"import/no-default-export": "off", // TODO@eamodio revisit
"import/no-duplicates": "error",
"import/no-self-import": "error",
"import/no-unresolved": ["warn", { "ignore": ["vscode", "ghpr", "git", "extensionApi"] }],
"import/order": [
"warn",
{
"groups": ["builtin", "external", "internal", ["parent", "sibling", "index"]],
"newlines-between": "ignore",
"alphabetize": {
"order": "asc",
"caseInsensitive": true
}
}
],
"@typescript-eslint/await-thenable": "error",
"@typescript-eslint/ban-types": "off", // TODO@eamodio revisit
// "@typescript-eslint/ban-types": [
// "error",
// {
// "extendDefaults": false,
// "types": {
// "String": {
// "message": "Use string instead",
// "fixWith": "string"
// },
// "Boolean": {
// "message": "Use boolean instead",
// "fixWith": "boolean"
// },
// "Number": {
// "message": "Use number instead",
// "fixWith": "number"
// },
// "Symbol": {
// "message": "Use symbol instead",
// "fixWith": "symbol"
// },
// "Function": {
// "message": "The `Function` type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with `new`.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape."
// },
// "Object": {
// "message": "The `Object` type actually means \"any non-nullish value\", so it is marginally better than `unknown`.\n- If you want a type meaning \"any object\", you probably want `Record<string, unknown>` instead.\n- If you want a type meaning \"any value\", you probably want `unknown` instead."
// },
// "{}": {
// "message": "`{}` actually means \"any non-nullish value\".\n- If you want a type meaning \"any object\", you probably want `object` or `Record<string, unknown>` instead.\n- If you want a type meaning \"any value\", you probably want `unknown` instead.",
// "fixWith": "object"
// }
// // "object": {
// // "message": "The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)).\nConsider using `Record<string, unknown>` instead, as it allows you to more easily inspect and use the keys."
// // }
// }
// }
// ],
"@typescript-eslint/consistent-type-assertions": [
"warn",
{
"assertionStyle": "as",
"objectLiteralTypeAssertions": "allow-as-parameter"
}
],
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/explicit-member-accessibility": "off",
"@typescript-eslint/explicit-module-boundary-types": "off", // TODO@eamodio revisit
// "@typescript-eslint/naming-convention": [
// "error",
// {
// "selector": "variable",
// "format": ["camelCase", "PascalCase"],
// "leadingUnderscore": "allow",
// "filter": {
// "regex": "^_$",
// "match": false
// }
// },
// {
// "selector": "variableLike",
// "format": ["camelCase"],
// "leadingUnderscore": "allow",
// "filter": {
// "regex": "^_$",
// "match": false
// }
// },
// {
// "selector": "memberLike",
// "modifiers": ["private"],
// "format": ["camelCase"],
// "leadingUnderscore": "allow"
// },
// {
// "selector": "memberLike",
// "modifiers": ["private", "readonly"],
// "format": ["camelCase", "PascalCase"],
// "leadingUnderscore": "allow"
// },
// {
// "selector": "memberLike",
// "modifiers": ["static", "readonly"],
// "format": ["camelCase", "PascalCase"]
// },
// {
// "selector": "interface",
// "format": ["PascalCase"]
// // "custom": {
// // "regex": "^I[A-Z]",
// // "match": false
// // }
// }
// ],
"@typescript-eslint/no-empty-function": "off",
"@typescript-eslint/no-empty-interface": "error",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-floating-promises": "off", // TODO@eamodio revisit
"@typescript-eslint/no-implied-eval": "error",
"@typescript-eslint/no-inferrable-types": "off", // TODO@eamodio revisit
// "@typescript-eslint/no-inferrable-types": ["warn", { "ignoreParameters": true, "ignoreProperties": true }],
"@typescript-eslint/no-misused-promises": ["error", { "checksConditionals": false, "checksVoidReturn": false }],
"@typescript-eslint/no-namespace": "off",
"@typescript-eslint/no-non-null-assertion": "off",
"@typescript-eslint/no-parameter-properties": "off",
"@typescript-eslint/no-this-alias": "off",
"@typescript-eslint/no-unnecessary-condition": "off",
"@typescript-eslint/no-unnecessary-type-assertion": "off", // TODO@eamodio revisit
"@typescript-eslint/no-unsafe-assignment": "off", // TODO@eamodio revisit
"@typescript-eslint/no-unsafe-call": "off", // TODO@eamodio revisit
"@typescript-eslint/no-unsafe-member-access": "off", // TODO@eamodio revisit
"@typescript-eslint/no-unsafe-return": "off", // TODO@eamodio revisit
"@typescript-eslint/no-unused-expressions": ["warn", { "allowShortCircuit": true }],
"@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }],
// "@typescript-eslint/no-unused-vars": [
// "warn",
// {
// "args": "after-used",
// "argsIgnorePattern": "^_",
// "ignoreRestSiblings": true,
// "varsIgnorePattern": "^_$"
// }
// ],
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/prefer-regexp-exec": "off", // TODO@eamodio revisit
"@typescript-eslint/prefer-nullish-coalescing": "off",
"@typescript-eslint/prefer-optional-chain": "off",
"@typescript-eslint/require-await": "off", // TODO@eamodio revisit
"@typescript-eslint/restrict-plus-operands": "error",
"@typescript-eslint/restrict-template-expressions": "off", // TODO@eamodio revisit
// "@typescript-eslint/restrict-template-expressions": [
// "error",
// { "allowAny": true, "allowBoolean": true, "allowNumber": true, "allowNullish": true }
// ],
"@typescript-eslint/strict-boolean-expressions": "off",
// "@typescript-eslint/strict-boolean-expressions": [
// "warn",
// { "allowNullableBoolean": true, "allowNullableNumber": true, "allowNullableString": true }
// ],
"@typescript-eslint/unbound-method": "off" // Too many bugs right now: https://github.com/typescript-eslint/typescript-eslint/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+unbound-method
}
}