Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate percentage change in stock price instead of raw stock price #26

Merged
merged 18 commits into from
Apr 18, 2024

Conversation

84ds84d8s
Copy link
Collaborator

No description provided.

@eric15342335 eric15342335 added the Comp: random Use of srand(), rand(), anything with the word "random" label Apr 17, 2024
@eric15342335 eric15342335 added this to the Fourth Meeting milestone Apr 17, 2024
Copy link
Owner

@eric15342335 eric15342335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually the make check has good explanation on what's wrong with your code, so I am not going to say the same thing twice

random_price.cpp Outdated Show resolved Hide resolved
random_price.cpp Outdated Show resolved Hide resolved
random_price.h Outdated Show resolved Hide resolved
random_price.h Outdated Show resolved Hide resolved
random_price.cpp Outdated Show resolved Hide resolved
eric15342335
eric15342335 previously approved these changes Apr 18, 2024
eric15342335
eric15342335 previously approved these changes Apr 18, 2024
Copy link
Owner

@eric15342335 eric15342335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested this

Prismatiscence
Prismatiscence previously approved these changes Apr 18, 2024
@eric15342335 eric15342335 dismissed stale reviews from Prismatiscence and themself via 32db764 April 18, 2024 18:48
@eric15342335
Copy link
Owner

Resolved a trivial merge conflict (nothing conflicts in my view). No need to review it again.

@eric15342335 eric15342335 merged commit 7e7980c into eric15342335:main Apr 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp: random Use of srand(), rand(), anything with the word "random"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants