-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up initial conditions #84
Conversation
f970450
to
0e0450a
Compare
@ericagol How should we proceed with the derivatives for the e=0 case? For now I just set anything that depends on ecosomega and esinomega 0, but that's not the correct way to handle the 1/e terms. |
I think we decided not to address this right now, so the user will have to assume a small eccentricity for modeling circular orbits. If we do address this, a paper by András Pál (2009) could be helpful: |
@ericagol Ok, I just set the derivatives to zero for now, and made a note about it in the documentation. Unless you see any issues, I'm going to go ahead and merge. |
Elements(m=1)
).ϖ
(\varpi
) toω
(\omega
) in code and fix terminology in docs.Elements
type.kepler_init
to handlee=0
.