Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up initial conditions #84

Merged
merged 8 commits into from
Jul 20, 2023
Merged

Fix up initial conditions #84

merged 8 commits into from
Jul 20, 2023

Conversation

langfzac
Copy link
Collaborator

@langfzac langfzac commented May 9, 2022

  • Allow integers to be given as parameter values (ie. Elements(m=1)).
  • Change ϖ (\varpi) to ω (\omega) in code and fix terminology in docs.
  • Allow circular orbits in initial conditions #83
    • Add additional orbital elements to Elements type.
    • Rework kepler_init to handle e=0.

@langfzac langfzac force-pushed the langfzac/ics branch 3 times, most recently from f970450 to 0e0450a Compare May 10, 2022 00:09
@langfzac
Copy link
Collaborator Author

@ericagol How should we proceed with the derivatives for the e=0 case? For now I just set anything that depends on ecosomega and esinomega 0, but that's not the correct way to handle the 1/e terms.

@ericagol
Copy link
Owner

@ericagol How should we proceed with the derivatives for the e=0 case? For now I just set anything that depends on ecosomega and esinomega 0, but that's not the correct way to handle the 1/e terms.

Good question @langfzac. I'll have to look into this.

@ericagol
Copy link
Owner

I think we decided not to address this right now, so the user will have to assume a small eccentricity for modeling circular orbits. If we do address this, a paper by András Pál (2009) could be helpful:

Pál (2009)

@langfzac langfzac marked this pull request as ready for review July 19, 2023 18:38
@langfzac
Copy link
Collaborator Author

langfzac commented Jul 19, 2023

@ericagol Ok, I just set the derivatives to zero for now, and made a note about it in the documentation. Unless you see any issues, I'm going to go ahead and merge.

@langfzac langfzac merged commit e0f272c into master Jul 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants