Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

ThirdPartyResources doesn't support AllNamespaces #61

Closed
JorritSalverda opened this issue Nov 15, 2017 · 0 comments · Fixed by #73
Closed

ThirdPartyResources doesn't support AllNamespaces #61

JorritSalverda opened this issue Nov 15, 2017 · 0 comments · Fixed by #73

Comments

@JorritSalverda
Copy link
Contributor

The following lines check whether a namespace is set for ThirdPartyResources:

https://github.com/ericchiang/k8s/blob/master/tprs.go#L105-L107

And since AllNamespaces is an empty string this leads to the error being returned. Kubectl supports --all-namespaces with my custom resources with scope: Namespaced fine though, so it seems superfluous to do this check.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant