This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
*: refactor generation and add type registration #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a large refactor of the library to add 1.9 support.
This is a large change because all types are now registered instead of being generated at the root of the repo. There are no more generated clients, just a common one that types are registered onto.
Changing the registration means:
client.CoreV1().CreateFoo
justclient.Create
.closes #70
closes #52
closes #63
closes #62
closes #61
closes #46
closes #66
Concretely creating a configmap went from:
To:
Get
,List
, andWatch
saw the biggest changes, with responses being passed as arguments instead of being return values. For example, aGet
now requires passing the type you want to decode into.Users can also register their own types using the
Register
andRegisterList
methods.Then
Create
,Update
,Delete
, andWatch
the custom type the same as other resources.TODOs before merge: