list/watch resources across all namespaces

[ultimateboy]

Fixes #21

[ericchiang]

@ultimateboy I was thinking about this recently and I don't know if I like the current behavior for Lists. E.g. that this

apps.ListPetSets(ctx, "")

Defaults to the client's "default" namespace. It's not very explicit.

Maybe we could make the "" value default to AllNamespaces like in the official client?

const (
    // AllNamespaces is given to list and watch operations to signify that the code should
    // list or watch resources in all namespaces.
    AllNamespaces = allNamespaces
    // Actual definition is private in case we want to change it later.
    allNamespace = ""
)

So you can do

apps.ListPetSets(ctx, k8s.AllNamespaces)

That would prevent adding more methods and clean up the ambiguous of

apps.ListPetSets(ctx, "")

What do you think?

[ultimateboy]

I'd be ok with this. I was actually kinda surprised that passing an empty string meant the pod's namespace instead of all-namespaces. I implemented it this way because it's what was in the original issue and I did not want to break backwards compatibility.

[ultimateboy]

@ericchiang Let me know if you want me to go ahead and update this PR with the proposed new direction. I would ask that you make a new release before we implement breaking changes.

[ericchiang]

@ultimateboy yep, go ahead and update. I'll create a release once you're done and call out the change.

[ultimateboy]

@ericchiang ready for review

[ericchiang]

@ultimateboy awesome! could you add a test? (also can you run the tests? I've only ever tried on my machine) https://github.com/ericchiang/k8s/blob/master/client_test.go

[ultimateboy]

@ericchiang Test has been added.

$ make test
go test -v ./...
=== RUN   TestNewTestClient
--- PASS: TestNewTestClient (0.03s)
=== RUN   TestHTTP2
--- PASS: TestHTTP2 (0.05s)
=== RUN   TestListNodes
--- PASS: TestListNodes (0.04s)
=== RUN   TestConfigMaps
--- PASS: TestConfigMaps (0.05s)
=== RUN   TestWatch
--- PASS: TestWatch (0.05s)
=== RUN   TestWatchNamespace
--- PASS: TestWatchNamespace (0.08s)
=== RUN   TestDiscovery
--- PASS: TestDiscovery (0.04s)
=== RUN   TestLabelSelector
--- PASS: TestLabelSelector (0.00s)
=== RUN   TestTPRs
--- PASS: TestTPRs (0.07s)
PASS
ok  	github.com/ericchiang/k8s	0.423s
?   	github.com/ericchiang/k8s/api/resource	[no test files]
?   	github.com/ericchiang/k8s/api/unversioned	[no test files]
?   	github.com/ericchiang/k8s/api/v1	[no test files]
?   	github.com/ericchiang/k8s/apis/apps/v1alpha1	[no test files]
?   	github.com/ericchiang/k8s/apis/apps/v1beta1	[no test files]
?   	github.com/ericchiang/k8s/apis/authentication/v1beta1	[no test files]
?   	github.com/ericchiang/k8s/apis/authorization/v1beta1	[no test files]
?   	github.com/ericchiang/k8s/apis/autoscaling/v1	[no test files]
?   	github.com/ericchiang/k8s/apis/batch/v1	[no test files]
?   	github.com/ericchiang/k8s/apis/batch/v2alpha1	[no test files]
?   	github.com/ericchiang/k8s/apis/certificates/v1alpha1	[no test files]
?   	github.com/ericchiang/k8s/apis/extensions/v1beta1	[no test files]
?   	github.com/ericchiang/k8s/apis/imagepolicy/v1alpha1	[no test files]
?   	github.com/ericchiang/k8s/apis/policy/v1alpha1	[no test files]
?   	github.com/ericchiang/k8s/apis/policy/v1beta1	[no test files]
?   	github.com/ericchiang/k8s/apis/rbac/v1alpha1	[no test files]
?   	github.com/ericchiang/k8s/apis/storage/v1beta1	[no test files]
?   	github.com/ericchiang/k8s/examples	[no test files]
?   	github.com/ericchiang/k8s/runtime	[no test files]
?   	github.com/ericchiang/k8s/util/intstr	[no test files]
?   	github.com/ericchiang/k8s/watch/versioned	[no test files]

[ericchiang]

lgtm!

[ericchiang]

@ultimateboy release is out https://github.com/ericchiang/k8s/releases/tag/v0.2.0