Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Success! (refs #5)
This PR makes several changes for this functionality to make sense:
grunt-angular-templates
(by @ericclemmons).ngtemplates:app
to generate angular moduleapp.templates
.app.templates
as a dependency ofapp
. Didn't think this was necessary, but it is for the module to instantiate.routes.view
, which is no longer necessarymin:*
andconcat:*
min
targets pivot off ofconcat
dest
keys, except performing.replace('.js', '.min.js')
, which is much more maintainable<link href="...">
and<script src="...">
generation. Instead, they rely on naming conventions likeapp.js
,app.css
,all.js
, etc.build/js/lib/angular.js
.views/home.html
for now until we have a better demo.@kwhitley I think this is in great shape! I did not change the module naming pattern, as the current angular "app" sucks, and I'd rather have a better demo.