Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile AngularJS Templates #20

Merged
merged 4 commits into from
Jan 9, 2013
Merged

Compile AngularJS Templates #20

merged 4 commits into from
Jan 9, 2013

Conversation

ericclemmons
Copy link
Owner

Success! (refs #5)

This PR makes several changes for this functionality to make sense:

  • Addition of grunt-angular-templates (by @ericclemmons).
  • Using ngtemplates:app to generate angular module app.templates.
  • REQUIRED Adding app.templates as a dependency of app. Didn't think this was necessary, but it is for the module to instantiate.
  • Removed routes.view, which is no longer necessary
  • Split apart libraries from the app in min:* and concat:*
  • min targets pivot off of concat dest keys, except performing .replace('.js', '.min.js'), which is much more maintainable
  • Removed dynamic <link href="..."> and <script src="..."> generation. Instead, they rely on naming conventions like app.js, app.css, all.js, etc.
  • Preferring GoogleCDN for Angular & ngResource. Falls back to build/js/lib/angular.js.
  • Removed the variables from views/home.html for now until we have a better demo.

@kwhitley I think this is in great shape! I did not change the module naming pattern, as the current angular "app" sucks, and I'd rather have a better demo.

@ghost ghost assigned ericclemmons Jan 9, 2013
@kwhitley
Copy link
Contributor

kwhitley commented Jan 9, 2013

No matter how many views you have, the templates.js only appears to compile/load a single template. Works for your example since there is only one template, but we need to broaden this coverage up to support more (and more varied cases).

@ericclemmons
Copy link
Owner Author

Ah, thanks! I'll patch that up.

@ericclemmons
Copy link
Owner Author

Resolved via ericclemmons/grunt-angular-templates/issues/1.

Now to pull v0.1.2

ericclemmons added a commit that referenced this pull request Jan 9, 2013
@ericclemmons ericclemmons merged commit 2d0e432 into master Jan 9, 2013
@ericclemmons ericclemmons deleted the 5-angular-templates branch January 9, 2013 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants