Skip to content
This repository

Fix concat option on windows #31

Merged
merged 1 commit into from about 1 year ago

2 participants

Trask Stalnaker Eric Clemmons
Trask Stalnaker
trask commented

Currently getting "unknown concat target" error on windows because the
concat target created by usemin uses the normalized path (with
backslashes on windows).

I needed to normalize the concat target in angular-template before looking
it up so it will work on windows also.

Trask Stalnaker trask Fix concat option on windows
Currently getting "unknown concat target" error on windows because the
concat target created by usemin uses the normalized path (with
backslashes on windows).

Need to normalize the concat target in angular-template before looking
it up so it will work on windows also.
de93e35
Eric Clemmons
Owner

Great catch! Merging...

Eric Clemmons ericclemmons merged commit 53d3990 into from
Eric Clemmons
Owner

Tagged & release v0.3.10 for you @trask. Thanks for the help, as I don't have a Windows machine available (and IIRC, grunt used to not work well on Windows at all!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jul 05, 2013
Trask Stalnaker trask Fix concat option on windows
Currently getting "unknown concat target" error on windows because the
concat target created by usemin uses the normalized path (with
backslashes on windows).

Need to normalize the concat target in angular-template before looking
it up so it will work on windows also.
de93e35
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 0 deletions. Show diff stats Hide diff stats

  1. +1 0  tasks/angular-templates.js
1  tasks/angular-templates.js
@@ -48,6 +48,7 @@ module.exports = function(grunt) {
48 48 var concat = grunt.config('concat') || {};
49 49
50 50 targets.forEach(function(target) {
  51 + target = path.normalize(target);
51 52 var task = concat[target];
52 53
53 54 if (!task) {

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.