Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TransitionGroup #89

Open
benbonnet opened this issue Sep 27, 2015 · 4 comments
Open

Support for TransitionGroup #89

benbonnet opened this issue Sep 27, 2015 · 4 comments
Milestone

Comments

@benbonnet
Copy link

Well I'm not 100% sure the problem relies here; but from what I understood so far, you seem to loose the ability to use the transition groups (or csstransitiongroups), because of the resolving
Glad to get some help on this one in any case

@benbonnet benbonnet changed the title Support for ReactCSSTransitionGroup Support for TransitionGroup Sep 27, 2015
@ericclemmons
Copy link
Owner

I haven't used ReactCSSTransitionGroup, but I'd imagine it's because of the HoC. If the ReactCSSTransitionGroup is on the inside of the component being resolved, it would work. But it's a good point, though.

I'd have to actually use it to see how the two would play together...

@benbonnet
Copy link
Author

basically, if the component resolves (does not renders right away), it won't work (at least on my side). I have been able to try on the examples too (#77). I'd be quite interest to know an alternative, or just your idea about transitioning pages with the resolver.

I've had random better results with this (https://github.com/Khan/react-components/blob/master/examples/timeout-transition-group.jsx). In any case, csstransitiongroup relies on transitionStart/End events, that does not seem that robust

@ericclemmons
Copy link
Owner

@bbnnt I'll be adding & publishing a @loader component (#72) that we've used internally, but it'd make sense to create a counter-version called @transition:

@transition(ReactCSSTransitionGroup, { ...props })
@resolve("user", () => someLongRequest)
class UserProfile ...

Similar to @loader, it would wait for resolution to complete before transitioning.

That's the problem: The transition is running against an empty element because the data hasn't loaded yet.

@ericclemmons ericclemmons added this to the v2 milestone Sep 27, 2015
@benbonnet
Copy link
Author

sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants