Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish @loading component #72

Open
4 tasks
ericclemmons opened this issue Aug 20, 2015 · 4 comments
Open
4 tasks

Publish @loading component #72

ericclemmons opened this issue Aug 20, 2015 · 4 comments
Milestone

Comments

@ericclemmons
Copy link
Owner

(So that other users can take advantage of this)

  • Provides the following props:
    • Boolean(loaded)
    • Array(promises)
  • Used via @loading(MyLoader)
@ericclemmons ericclemmons added this to the v2 milestone Aug 20, 2015
@ericclemmons ericclemmons changed the title Publisher @loading component Publishe @loading component Aug 20, 2015
@ericclemmons ericclemmons changed the title Publishe @loading component Publish @loading component Aug 20, 2015
@ericclemmons
Copy link
Owner Author

That wouldn't really be a good idea, since the purpose was to remove the
statefulness out of the decorated component.

There's a new owner to this repo, so hopefully it gets released soon.

On Wed, Mar 2, 2016 at 9:57 AM Evgueni Naverniouk notifications@github.com
wrote:

Until this lands, is there some other way we can pass a "isLoading" prop
down to our decorated component?


Reply to this email directly or view it on GitHub
#72 (comment)
.

  • Eric Clemmons

@livemixlove
Copy link

Can someone point me in the right direction to add this myself? I just put a bunch of work into using resolver in my project, and just now I'm realising there's not a good way to set state/props based on loading. Workarounds?

@lennerd
Copy link

lennerd commented Jul 20, 2017

Same here. I really like the API but really miss the possibility to add some kind of loading indicator.

@ericclemmons
Copy link
Owner Author

I admittedly haven't looked at this in a while, but felt bad & started working on it, then noticed this:

https://github.com/ericclemmons/react-resolver/blob/master/examples/react-v15/src/components/Stargazers.js#L8

What am I missing out on here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants