Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to react 16 #134

Merged
merged 1 commit into from Apr 18, 2018
Merged

Conversation

didi0613
Copy link
Contributor

No description provided.

@ajoshi0
Copy link

ajoshi0 commented Jan 11, 2018

@@janicetyp please can you review this and get this merged if its all good

@ajoshi0
Copy link

ajoshi0 commented Jan 12, 2018

@jphillips-ua any luck on this please let us know

@didi0613
Copy link
Contributor Author

Any updates on this one? Please let us know.
Thank you

@pwmckenna pwmckenna merged commit 7b1e3a7 into ericclemmons:master Apr 18, 2018
@pwmckenna
Copy link
Collaborator

@didi0613 @ajoshi0 sorry for the delay. merged and released as 3.1.2

@didi0613
Copy link
Contributor Author

didi0613 commented Apr 30, 2018

@pwmckenna Hi, thanks for the update. After upgrading to 3.2.1, I am still getting this:

npm WARN react-resolver@3.1.2 requires a peer of react@^0.14.6 || ^15.0.0-0 but none is installed. You must install peer dependencies yourself.
npm WARN react-resolver@3.1.2 requires a peer of react-dom@^0.14.6 || ^15.0.0-0 but none is installed. You must install peer dependencies yourself.

Can you please help to check?

@madprog
Copy link

madprog commented Nov 9, 2018

@didi0613 it looks like the tag was made on a wrong commit:

* 44a61e8 (tag: v3.1.2) 3.1.2
| * 7b1e3a7 (HEAD -> master, upstream/master, upstream/HEAD) upgrade to react 16 (#134)
|/  
* 4151b08 (tag: v3.1.1) 3.1.1

@pwmckenna Could you check that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants