-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart on every rebuild #30
Comments
are you using the @beta versionz/
|
I'm on 2.2.5 |
Ok, try the @beta version
Wout.
…On Thu, Oct 4, 2018 at 3:15 PM Antony ***@***.***> wrote:
I'm on 2.2.5
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADWloKK1XFCEdh9FqiQghKy6n4K50Jzks5uhgndgaJpZM4XHq_C>
.
|
I'm not seeing it under version? |
As a separate confirmation, our team is seeing this problem more-or-less as a matter of course with 2.2.5 running under macOS. I'll try the beta and see how that goes. |
Some quick debugging suggests that this function is wrong:
On the first pass, the code finds the connected worker, kills the server, and then returns the callback. The server is now dead (killed), but not restarted. On the second save, the if() clause doesn't trigger, so the server is started. Note that this only happens when |
Quick follow-up: our HMR was configured in poll mode, but start-server-webpack-plugin was configured with Upon careful reading of the start-server-webpack-plugin, I think the documentation technically says this, but HMR hard enough for us to get configured (and not completely working until now) that I wonder if:
(One of the other tell-tales of our misconfiguration is that @antonyisoardi -- any chance the same issue for you? Short version: I think this plugin works correctly as long as the configuration exactly matches the HMR configuration. However, if there is a mismatch, there are some subtle bugs where it would be nice if there was catastrophic failure. |
For my setup, But, |
Hey, so is there any way to enable restart on rebuild without HMR? |
Not so sure if anyone else has experienced this, BUT!... I've noticed that the server is only being restarted on every second rebuild.
Rebuilds are successful every time, however in order for me to get the server restarted I have to make a second change.
The text was updated successfully, but these errors were encountered: