Migrate source code to ESM #1035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update JavaScript from CJS to ESM where possible. The ESLint configuration cannot be converted until we upgrade to ESLint v9, everything else is updated. Note that the build output is still CJS, hence the change to the name of the build output.
github-actions
bot
added
dependencies
Make the Mocha configuration dynamic to support different configuration based on the current Node.js version. This is necessary because older supported Node.js versions require the "loader" option while newer versions require the "import" option. The configuration file must be in CJS because Mocha doesn't support ESM yet.
|
Given the various "hacks" necessary to make this work (dynamic Mocha configuration, setting This may be revisited later. |
ericcornelissen
removed
test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175
Summary
Update JavaScript from CJS to ESM where possible.
The ESLint configuration cannot be converted until we upgrade to ESLint v9, everything else is updated. Similarly, the Mocha configuration cannot be converted because Mocha does not yet support ESM-based configuraiton files.
Note that the build output is still CJS, hence the change to the name of the build output.