Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for paths that are not valid Rust Strings #65

Closed
ericcornelissen opened this issue Jun 13, 2023 · 0 comments · Fixed by #70
Closed

Add support for paths that are not valid Rust Strings #65

ericcornelissen opened this issue Jun 13, 2023 · 0 comments · Fixed by #70
Assignees
Labels
enhancement New feature or request

Comments

@ericcornelissen
Copy link
Owner

Feature Request

Summary

Currently, rm only supports paths that are valid Rust strings due to the use of String in the CLI Args definition:

rust-rm/src/main.rs

Lines 102 to 103 in 330275d

/// The paths to remove.
paths: Vec<String>,

This limits what paths can be removed to those paths that can be represented by a Rust String. However, depending on the system, paths could contain characters that cannot be represented by this type. Hence, the Rust OsString should be used instead to make sure any file can be rmed.

Notes

This was originally raised in #38 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant