Remove the no_color.rs integration test
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the integration tests to exclude the suite for color/ansi formatting testing. The test suite currently doesn't function - removing line 51 yields the same test results, proving the `NO_COLOR` environment variable is not what's suppressing ANSI formatting in the suite. The test is being removed here as a precaution to avoid false confidence that the suite provides any guarantees w.r.t. `NO_COLOR` support by this application. As of this commit no alternative testing strategy for this purpose was found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #5, #13, #14
Summary
Remove the
no_color.rsintegration test suite for color/ANSI formatting testing. Besides not being named correctly1, the test suite currently doesn't function correctly. This can be observed by removing line 51. This yields identical test results, thus proving theNO_COLORenvironment variable is not what's suppressing ANSI formatting in the suite.Motivation
The test is being removed here as a precaution to avoid false confidence that the suite provides any guarantees w.r.t.
NO_COLORsupport by this application2. As of this Pull Request no alternative testing strategy for this purpose was found.Footnotes
no_color_test.rswould align with integration test suite names,color_test.rsoransi_test.rswould've been even better. ↩Note that based on manual testing
NO_COLORis properly supported. ↩