Support more valid shell names on Windows #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1137 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 709 709
=========================================
Hits 709 709
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ericcornelissen
force-pushed
the
win-no-exe
branch
from
e6cd5fb
to
15536e2
Compare
ericcornelissen
force-pushed
the
win-no-exe
branch
from
54d7ec6
to
58672a4
Compare
ericcornelissen
changed the title
.exe included
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1125
Summary
Update how shell names for Windows are handled in order to support shell names specified without extension (
.exe).