Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export as Stubscape from shescape/testing #1308

Merged
merged 6 commits into from
Dec 7, 2023

Commits on Nov 22, 2023

  1. Re-export as Stubscape from shescape/testing

    Simplify importing the default stub implementation of Shescape as
    `Stubscape` by re-exporting it under that name.
    
    As of writing, I'm not sure whether exporting this stub as `Shescape` or
    `Stubscape` is better. I think both have pros and cons. In any case, the
    export named `Shescape` can't just be removed because that would be a
    breaking change.
    ericcornelissen committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    d89ab28 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Configuration menu
    Copy the full SHA
    7871087 View commit details
    Browse the repository at this point in the history
  2. Mark Stubscape as an alias of Shescape

    Avoid vetting error by knip by marking `Stubscape` as an alias of
    `Shescape` in its documentation. Besides making knip happy, this also
    makes the re-export more explicit and hopefully clear in context.
    
    To support this, `Shescape` was renamed to `Stubscape` and `Shescape`
    now re-exports `Shescape`. This makes semantic sense (I want `Stubscape`
    to be the "correct" export, and `Shescape` an alias for backwards
    compatibility), but is also required as the (at)alias tag needs to be on
    the re-exporting expression for knip to accept it.
    ericcornelissen committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    1989a1a View commit details
    Browse the repository at this point in the history
  3. Update the changelog

    ericcornelissen committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    760c418 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Configuration menu
    Copy the full SHA
    87dd76e View commit details
    Browse the repository at this point in the history
  2. Update testing.d.ts

    Add `Stubscape` export to testing.d.ts and align documentation with
    corresponding testing.js code.
    ericcornelissen committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    2742c8a View commit details
    Browse the repository at this point in the history