Lint for & remove side-effects #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the dependency on eslint-plugin-top and replace it by a fork created by me that excludes top-level literal assignments to `const`. I did also propose adding this to eslint-plugin-top, but in the meantime we can use this fork (as eslint-plugin-top doesn't seem to be actively maintained anyway).
ericcornelissen
force-pushed
the
207-lint-side-effects
branch
from
fc797b3
to
bfc8ab9
Compare
ericcornelissen
force-pushed
the
main
branch
from
97b6ba5
to
f42fc7d
Compare
By replacing the `Map`ping from shell to escape/quote function by a simple switch statement.
ericcornelissen
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #207