Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSDoc to index.d.ts #568

Merged
merged 6 commits into from
Dec 23, 2022
Merged

Add JSDoc to index.d.ts #568

merged 6 commits into from
Dec 23, 2022

Conversation

ericcornelissen
Copy link
Owner

@ericcornelissen ericcornelissen commented Dec 5, 2022

Add JSDoc to the type definitions for better IDE support.

Unfortunately this means some JSDoc is duplicated between index.js and index.d.ts - ideally a resolution for this is found...

@ericcornelissen ericcornelissen added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Dec 5, 2022
Verbatim copy includes some redundant information for TypeScript (as
it's encoded by the types), but makes it simpler to maintain as there's
no manual changes required when copy the documentation from `index.js` to
`index.d.ts`.
@ericcornelissen ericcornelissen enabled auto-merge (squash) December 23, 2022 20:59
@ericcornelissen ericcornelissen merged commit 6c7ee30 into main Dec 23, 2022
@ericcornelissen ericcornelissen deleted the inline-docs-for-types branch December 23, 2022 21:00
@ericcornelissen ericcornelissen removed the help wanted Extra attention is needed label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant