Fix quoting bug for trailing \! for C shell
#675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the test fixtures for `csh` to include examples of arguments with the substring `"\!"` to ensure they are escaped properly. In particular, the test case `"a\!"` is currently not escaped correctly by Shescape, so this test acts as a regression test. The other tests are included for completeness and to avoid regression against the current implementation when fixing the current bug. Additionally, include a new fuzz corpus entry which shows that it is really only trailing `"\!"` substrings that aren't handled correctly. It will blow up if `"\!"` in the middle of an argument is over-escaped.
Codecov Report
@@ Coverage Diff @@
## main #675 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 901 904 +3
=========================================
+ Hits 901 904 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ericcornelissen
force-pushed
the
csh-fuzz-crash
branch
from
f545901
to
acc75b5
Compare
ericcornelissen
changed the title
\! for C shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #659
Found by nightly fuzzing (Jan 22)
Summary
Quoting for C shell does not work as expected when the argument ends with the substring
"\!". After quoting such an argument, the resulting argument interpreted by C shell will be"!", while after quoting should still be"\!".This bug has no security implications, it may just result in unexpected strings being passed to the program being invoked.