Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to counsel-projectile-find-file to visit directory #129

Closed
wants to merge 1 commit into from
Closed

Add action to counsel-projectile-find-file to visit directory #129

wants to merge 1 commit into from

Conversation

manuel-uberti
Copy link
Contributor

This PR aims to mirror abo-abo/swiper#2057

If you need me to change anything, feel free to ask.

@ericdanan
Copy link
Owner

ericdanan commented May 13, 2019

Thanks for the PR. You can already open the current counsel-projectile-find-file (or counsel-projectile) candidate's directory with dired by hitting M-o m RET:

  • M-o m will open counsel-find-file at the current candidate's directory,

  • Since the first candidate ./ is preselected, RET will open the directory in dired.

That also gives access to other counsel-find-file actions such as copy or move so opening the directory in dired is sometimes not necessary. Only downside I see is one additional keystroke to open dired, which is not a big deal for me. What do you think?

@manuel-uberti
Copy link
Contributor Author

Didn't know about M-o m, to be honest.

It's a bit quicker with the code in the PR, but I do not want to duplicate an existing functionality. It's already fine as you implemented, so I'm closing this and will be using your solution. :)

Thank you!

@ericdanan
Copy link
Owner

You're welcome. Keep in mind that you can simply add the action in your setup if you want the extra speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants