Skip to content

Commit

Permalink
fix cran issues
Browse files Browse the repository at this point in the history
  • Loading branch information
ericdunipace committed Jan 23, 2024
1 parent d9ce201 commit 8146952
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
9 changes: 7 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: WpProj
Type: Package
Title: Linear p-Wasserstein Projections
Version: 0.2
Version: 0.2.1
Date: 2024-01-19
Authors@R:
c(
Expand All @@ -10,6 +10,10 @@ Authors@R:
email = "edunipace@mail.harvard.edu",
role = c("aut", "cre"),
comment = c(ORCID = "0000-0001-8909-213X")),
person(given = "Andrew",
family = "Johnson",
role = c("ctb"),
comment = c(ORCID = "0000-0001-7000-8065")),
person(given = "Clemens",
family = "Schmid",
role = c("ctb"),
Expand Down Expand Up @@ -89,7 +93,8 @@ Suggests:
testthat (>= 2.1.0),
transport,
Rmosek,
spelling
spelling,
ECOSolveR
RoxygenNote: 7.2.3
Roxygen: list(markdown = TRUE)
URL: https://github.com/ericdunipace/WpProj
Expand Down
3 changes: 2 additions & 1 deletion tests/testthat/test-transport_plan.R
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ testthat::test_that("transport rank works", {
observation.orientation = "colwise",
method = method, is.X.sorted = TRUE)

testthat::skip_on_cran()
# compare C order to R order
testthat::expect_true(sum(x_idx-transx$tplan$from !=0) <= 2) #two obs flipped

Expand Down Expand Up @@ -179,7 +180,7 @@ testthat::test_that("transport rank works", {
# testthat::expect_null(transx$cost)
# testthat::expect_null(transy$cost)
# testthat::expect_null(trans.nothing$cost)
testthat::skip_on_cran()

testthat::skip_on_ci()
testthat::expect_equal(x_idx[507], transx$tplan$from[508])
testthat::expect_equal(y_idx, transy$tplan$from)
Expand Down

0 comments on commit 8146952

Please sign in to comment.