Fix for broken applitude reference #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a similar error to issue paralleldrive#41, and found these changes to ```./dist/browser-cuid.js``` fixed it for me. It wasn't obvious where these files were generated, so I kept the direct changes.
Remove reference to applitude and test for app.
2 tasks
ericelliott
added a commit
that referenced
this pull request
Nov 11, 2015
Fix for broken applitude reference
|
@ericelliott I would like to request a publish to npm based on this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an error similar to issue #41 when using cuid as a dependency of a dependency (but not a a direct dependency, strangely). These minor changes allowed cuid to be used without error.
There may well be broader consequences of these changes, and I'm happy to provide covering tests and such if you can provide some guidance about how the dist files are generated,