Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to Applitude #41

Closed
1 of 2 tasks
ericelliott opened this issue Aug 20, 2015 · 8 comments
Closed
1 of 2 tasks

Remove all references to Applitude #41

ericelliott opened this issue Aug 20, 2015 · 8 comments

Comments

@ericelliott
Copy link
Collaborator

Applitude is defunct. It's past time to remove references to it from Cuid.

  • Docs
  • Tests
@vasco3
Copy link

vasco3 commented Sep 29, 2015

I'm getting this error when using babel-node

> babel-node --ignore '/node_modules/(?!server|client|lib|healthcheck)' app/test/unit/index.js | tap-bail

/var/repositories/universal-react-boilerplate/node_modules/bunyan-request-logger/node_modules/cuid/dist/node-cuid.js:92
})(undefined.applitude || undefined);
            ^
TypeError: Cannot read property 'applitude' of undefined
    at Object.<anonymous> (/var/repositories/universal-react-boilerplate/node_modules/bunyan-request-logger/node_modules/cuid/dist/node-cuid.js:105:3)
    at Module._compile (module.js:460:26)
    at normalLoader (/var/repositories/universal-react-boilerplate/node_modules/babel-core/lib/api/register/node.js:199:5)
    at Object.require.extensions.(anonymous function) [as .js] (/var/repositories/universal-react-boilerplate/node_modules/babel-core/lib/api/register/node.js:216:7)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/var/repositories/universal-react-boilerplate/node_modules/bunyan-request-logger/request-logger.js:8:10)
    at Module._compile (module.js:460:26)

is this related?

@ericelliott
Copy link
Collaborator Author

Yes.

gjcoombes added a commit to gjcoombes/cuid that referenced this issue Nov 11, 2015
I had a similar error to issue paralleldrive#41, and found these changes to ```./dist/browser-cuid.js``` fixed it for me.
It wasn't obvious where these files were generated, so I kept the direct changes.
@gjcoombes
Copy link
Contributor

Hi Eric, PR #53 is a minor tweak that fixed things for me. Happy to improve the changes as you see fit.

@viveleroi
Copy link

Can you please release a new NPM version with this fix, we need this as well. Thanks

viveleroi added a commit to helion3/inspire-tree that referenced this issue Mar 30, 2016
For now, only making use of imports for slightly cleaner code.

Due to a cuid bug, we have to use the latest master because the fix has yet to be published.

paralleldrive/cuid#41
@kirilpopov
Copy link

Can you publish new NPM version - we're dropping this wonderful package from our project , because the applitude thing is breaking our build with webpack. Thanks

@ericelliott
Copy link
Collaborator Author

The current version is not publishable. It has not been properly tested and will likely break existing projects that depend on it. When the tests can run and pass in browsers, I will publish.

PRs are welcome. See this issue for context.

@Flet
Copy link
Contributor

Flet commented Jan 3, 2018

Hello!

It looks like some awesome work was done in #72 to resolve this issue and a new version was created here in GitHub, but v2.0.0 was never published to npm.

Is it possible to publish v2.0.0 to npm?

Are there still reservations around breaking projects with this version? If so, is it possible to publish under a tag to allow folks to try it? (i.e. npm publish --tag beta)

@ericelliott
Copy link
Collaborator Author

Published as v2.0.1

bengourley added a commit to bugsnag/bugsnag-js that referenced this issue Mar 9, 2018
The version of cuid used did not play well with rollup's bundling, due to this issue:
paralleldrive/cuid#41. When cuid was added to bugsnag, an update wasn't
available, but v2.x was published in sept 2017 which fixes this issue. All we needed to do is
upgrade the dependency.
bengourley added a commit to bugsnag/bugsnag-js that referenced this issue Mar 9, 2018
The version of cuid used did not play well with rollup's bundling, due to this issue:
paralleldrive/cuid#41. When cuid was added to bugsnag, an update wasn't
available, but v2.x was published in Jan 2018 which fixes this issue. All we needed to do is
upgrade the dependency. Unfortunately the updates broke for ie8 in the process (which we need
to support) so we depend on our forked version for now.
bengourley added a commit to bugsnag/bugsnag-js that referenced this issue Mar 15, 2018
The version of cuid used did not play well with rollup's bundling, due to this issue:
paralleldrive/cuid#41. When cuid was added to bugsnag, an update wasn't
available, but v2.x was published in Jan 2018 which fixes this issue. Unfortunately the updates
broke for ie8 in the process (which we need to support) so we are maintaining a fork, which is
published at @bugsnag/cuid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants