New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function builtin expanded notation #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See question.
@ericelliott I don't wanna be annoying but better be safe than sorry: squash the commits. |
Why? |
To have a cleaner history? One commit per PR is a good rule of thumb. And GitHub supports it in its interface directly. |
I prefer a more complete and accurate history. Does this actually block your workflow if it's not squashed, or is it just one of your pet peeves? =) If it impedes your workflow, please give me an example of HOW it impedes your workflow. |
Here's a blog post that explains it in details: https://blog.github.com/2016-04-01-squash-your-commits/#whats-changing On all the open sources projects that Iv contributed to, the maintainers squash the commits that result from a review. It's not my pet peeve, it's just a convention on GitHub. I mean it was quite obvious that a On my personal projects, I go even further and respect the conventional commits specification. |
Ah, so pet peeve. ;) |
You should not be proud of having Well anyway, we are not on the same page on this so Ill squash myself. |
ce53293
to
9483a39
Compare
@ericelliott LGTM |
We should be more descriptive about what feature we're updating. =) |
This detail was missing from the specification.