Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Testing Actions #17

Closed
charasyn opened this issue Oct 15, 2020 · 2 comments · Fixed by #40
Closed

GitHub Testing Actions #17

charasyn opened this issue Oct 15, 2020 · 2 comments · Fixed by #40
Assignees

Comments

@charasyn
Copy link
Collaborator

Hey, I'm trying to write the section about the testing framework for A1, and I had a few questions about the GitHub testing.
Does anyone know if the testing actions are set up on GitHub at the moment? I don't think they are, since otherwise it would be checking each pull request we submit, right?
To my understanding we're supposed to have automated testing on every change that goes into the codebase - is that right? If so I can set it up after A1 is done, I just have to know what to put in response to "[our team's] understandings of when and how the test cases will be running directly on GitHub".

@charasyn
Copy link
Collaborator Author

I've created a PR: #18
Please check that and comment with any inaccuracies or additional details that aren't yet captured there.
I will keep this issue open to track the implementation of the automated testing.

@charasyn charasyn self-assigned this Oct 15, 2020
@charasyn
Copy link
Collaborator Author

This was resolved with PR #40 . Thanks Eric!

@charasyn charasyn linked a pull request Nov 19, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant